feat: add system test (latest release + from source) to PR checks#617
Open
LuukBlom wants to merge 7 commits into
Open
feat: add system test (latest release + from source) to PR checks#617LuukBlom wants to merge 7 commits into
LuukBlom wants to merge 7 commits into
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
system test used to be run only for releases.
Since they run relatively quickly, they can just be parallel runs for every PR.
Runnning the test actually raised some errors that are now also fixed (see files changed)
TODO
feel free to edit / add / remove:
Note: I had to do quite some updates to the existing system test, and the errors raised by delft fiat are quite cryptic to resolve, especially for users that are not aware of the changes.
I think it would be valuable to do some basic sanity checks in hydromt-fiat before writing to disk with some informative error messages (exposure and vuln have valid data and are linked etc).